- Apr 08, 2020
-
-
Eloy Durán authored
-
Bruno Barbieri authored
Summary: This PR fixes a compatibility issue with the Vibration module and TurboModules. The TurboModules spec doesn't allow nullable arguments of type Number, causing the following problem:  [iOS] [Fixed] - Make Vibration library compatible with TurboModules. Pull Request resolved: https://github.com/facebook/react-native/pull/27951 Test Plan: Just submitted a PR to my own app to fix the issue [here](https://github.com/rainbow-me/rainbow/pull/340) The problem should be reproducible on RNTester due to this line: https://github.com/facebook/react-native/blob/91f139b94118fe8db29728ea8ad855fc4a13f743/RNTester/js/examples/Vibration/VibrationExample.js#L66 and should be working on this branch. Reviewed By: TheSavior Differential Revision: D19761064 Pulled By: hramos fbshipit-source-id: 84f6b62a2734cc09d450e906b5866d4e9ce61124
-
Javier Cuevas authored
Summary: The `:configuration` option from `pod` only affects the specified pod and not its dependencies [1]. Therefore in order to avoid all transitive dependencies being linked in the resulting Release IPA we need to list them in the `Podfile`. Note that this will still build Flipper's pods when doing a Release, but it won't link it in the resulting IPA. [1] https://guides.cocoapods.org/syntax/podfile.html#pod Fixes https://github.com/react-native-community/upgrade-support/issues/28 Related https://github.com/CocoaPods/CocoaPods/issues/9658 * [iOS] [Fixed] - Exclude Flipper from iOS Release builds Pull Request resolved: https://github.com/facebook/react-native/pull/28504 Test Plan: Create a new React Native 0.62 project, run `pod install`, then diff: ``` ProjectName/ios/Pods/Target Support Files/Pods-ProjectName/Pods-ProjectName.debug.xcconfig` ``` and ``` ProjectName/ios/Pods/Target Support Files/Pods-ProjectName/Pods-ProjectName.relaese.xcconfig ```  Reviewed By: passy Differential Revision: D20894406 Pulled By: priteshrnandgaonkar fbshipit-source-id: 680780f0f5a85fd8423b85a271a499bd12f06d00
-
Eli White authored
Summary: The appearance module uses sync native module methods which doesn't work with the chrome debugger. This broke in 0.62: https://github.com/facebook/react-native/issues/26705 This fix makes the appearance module return 'light' when using the chrome debugger. Changelog: [Fixed] Appearance `getColorScheme` no longer breaks the debugger Reviewed By: yungsters Differential Revision: D20879779 fbshipit-source-id: ad49c66226096433bc9f270e004ad4a6f54fa8c2
-
Eli White authored
Summary: This is an internal only module that we use to detect whether we are in async debugging mode. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D20879780 fbshipit-source-id: 5915f4e1c54a3fda0cf607c77f463120264fdbc4
-
Hein Rutjes authored
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: https://github.com/facebook/react-native/issues/28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: https://github.com/facebook/react-native/pull/28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR https://github.com/expo/react-native/pull/21 has been shipped and tested in Expo Client 37 Fixes https://github.com/facebook/react-native/issues/28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
-
Sergio Estevao authored
Summary: This PR adds the `isFocused` method to the mock of the TextInput component. My understanding some of the latest changes on the TextInput to make it use a forwardRef change the way this method is mock giving an error when trying to use in on a mock. The change suggested here fixes the issue. ## Changelog [JavaScript] [Fixed] - Fix the mock for TextInput to support the `isFocused` method Pull Request resolved: https://github.com/facebook/react-native/pull/28332 Reviewed By: cpojer Differential Revision: D20538044 Pulled By: TheSavior fbshipit-source-id: be734af105ab62ffdf9ed4017bd70845e207f8cd
-
- Apr 07, 2020
-
-
Eloy Durán authored
[General] [Fixed] Flow errors from YellowBox and BubblingEventHandler
-
- Apr 03, 2020
-
-
Michał Pierzchała authored
-
Eloy Durán authored
-
Eloy Durán authored
-
Eloy Durán authored
Summary: The [previous attempt](https://github.com/facebook/react-native/pull/28304) to fix the publish step failed, so now reverting to manually configuring things. This PR adds an entry to SSH’s `known_hosts` file using github.com’s public key that I have verified as per [these instructions](https://serverfault.com/a/807363): ``` ~/C/R/react-native [master] » nmap github.com --script ssh-hostkey Nmap scan report for github.com (140.82.118.4) rDNS record for 140.82.118.4: lb-140-82-118-4-ams.github.com PORT STATE SERVICE 22/tcp open ssh | ssh-hostkey: | 1024 ad:1c:08:a4:40:e3:6f:9c:f5:66:26:5d:4b:33:5d:8c (DSA) |_ 2048 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48 (RSA) ``` These fingerprints line up with [the ones posted by GitHub](https://help.github.com/en/github/authenticating-to-github/githubs-ssh-key-fingerprints), so my setup should be good and can be trusted to grab the public key from the right host: ``` ~/C/R/react-native [master] » ssh-keyscan -t rsa -H github.com |1|If6MU203eXTaaWL678YEfWkVMrw=|kqLeIAyTy8pzpj8x8Ae4Fr8Mtlc= ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ== ``` [Internal] [Fixed] - Make automated publishing of packages from CI work again Pull Request resolved: https://github.com/facebook/react-native/pull/28370 Test Plan: I used the command being added in this PR in [a failed CI job](https://app.circleci.com/pipelines/github/facebook/react-native/4104/workflows/916127cb-177f-4583-9f90-cae5318041d8/jobs/140810). When I invoked the publish script manually I was not greeted by the blocking prompt and the package was successfully published: https://www.npmjs.com/package/react-native/v/0.0.0-56cf99a96 Reviewed By: cpojer Differential Revision: D20601527 Pulled By: hramos fbshipit-source-id: b1a4405228408cfc4a1b3b44ab88c79522af3a66
-
Eloy Durán authored
-
grabbou authored
[iOS] [Fixed] - Revert [previous incomplete fix](https://github.com/facebook/react-native/commit/bd2b7d6c0366b5f19de56b71cb706a0af4b0be43) for [an issue](https://github.com/facebook/react-native/issues/26473) with `Modal`’s `onDismiss` prop. This reverts commit bd2b7d6c.
-
Jesse Katsumata authored
Summary: Some of the repository name of Lean Core(https://github.com/facebook/react-native/issues/23313) libraries has been renamed. This PR updates the warning message to display the updated url. [General] [Changed] - Update warning message of deprecated imports Pull Request resolved: https://github.com/facebook/react-native/pull/28452 Test Plan: updated URL can be accessed. Reviewed By: cpojer Differential Revision: D20745184 Pulled By: TheSavior fbshipit-source-id: 2c3ed6a000b45022ca6c4862305aa567c4d18b2e
-
Martin Sherburn authored
Summary: onEndReached can be triggered twice when more items are added to the end of the list. This change makes it so that a second call to onEndReached won't happen until the user scrolls down to the new end of the list. Changelog: [General] [Fixed] - Fix double call to onEndReached in VirtualizedList Reviewed By: sahrens Differential Revision: D20066740 fbshipit-source-id: 129d7ae6bfd241eeea18fe0bb12b82be67735874
-
Janic Duplessis authored
Summary: JNI now comes from https://github.com/facebookincubator/fbjni and it uses a different DoNotStrip class (https://github.com/facebookincubator/fbjni/blob/master/java/com/facebook/jni/annotations/DoNotStrip.java) so we need to include it in the proguard config. ## Changelog [Android] [Fixed] - Add new DoNotStrip class to proguard config Pull Request resolved: https://github.com/facebook/react-native/pull/27934 Test Plan: Test that it fixes a crash related to missing NativeRunnable class in release builds. Differential Revision: D19690580 Pulled By: cpojer fbshipit-source-id: cb4e2eaae35fb3a9d68f04c57cc973914207be73
-
Mo Gorhom authored
Summary: Hi There
👋 , While I'm developing on iOS with dark appearance enabled, i notice that `Pref Monitor` view doesn't support dark mode yet, so here is the PR to fix it :) ## Changelog [iOS] [Fixed] - Fix Pref Monitor in dark appearance Pull Request resolved: https://github.com/facebook/react-native/pull/28130 Test Plan: Run any React Native app on iOS > Turn on dark appearance ### Before  ### After  Reviewed By: RSNara Differential Revision: D20080019 Pulled By: PeteTheHeat fbshipit-source-id: 9365daa3f7193a11760bc1372b8de2c3896def5c -
Emilio authored
Summary: React Native ScrollViews are flipped upside down when the prop inverted is set to true. This is the root of a bug: tapping on the status bar in iOS should scroll the Flatlist up to the top but currently it does to the bottom. The solution proposed is to detect natively if the ScrollView is inverted, on such case, prevent it from scrolling it to the beginning of the ScrollView (as a non-inverted ScrollView would do) and force a scroll to the end of it. I've been careful enough not to force the scroll if the user explicitly selected not to do it or if it's happening in a nested ScrollView, as it is the default behaviour in iOS. Fixes https://github.com/facebook/react-native/issues/21126 ## Changelog [iOS] [Fixed] - Inverted ScrollViews scroll to their bottom when the status bar is pressed Pull Request resolved: https://github.com/facebook/react-native/pull/27574 Test Plan: - on iOS, add a ScrollView and put enough content to overflow the screen size so it can be scrolled - add the prop `inverted={true}` to the ScrollView - go to the screen the Scrollview is in and press the status bar - it should scroll to top (previously it scrolled to the bottom)  Differential Revision: D19185270 Pulled By: hramos fbshipit-source-id: 5445093ff38f4ba4082f1d883d8ed087e9565eaf
-
- Mar 31, 2020
-
-
Ricky authored
-
- Mar 26, 2020
-
-
Eloy Durán authored
-
- Mar 18, 2020
-
-
Tim Yung authored
Summary: The current implementation of `Pressability` has a bug related to `onLongPress`. When a user starts a press gesture, we keep track of the activation position (occurs after waiting `delayPressIn` milliseconds). If the touch moves away from that position by more than 10dp, we rule out the long press gesture. This means no matter how long you hold down the press, even if you move it back to within 10dp, we will not fire `onLongPress`. However, there is currently a bug where we never reset the cached activation position. This means that after the first press gesture, all subsequent long press gestures must start within 10dp of that first press gesture. This leads to seemingly intermittent missing long press gestures. This fixes the bug by ensuring that whenever a press gestures is terminated (either via a cancel or release), we reset the activation position. Changelog: [General][Fixed] - Fixed Pressability to properly fire `onLongPress`. Reviewed By: TheSavior Differential Revision: D20410075 fbshipit-source-id: e4727b7a9585ce3ea39481fc13e56b6b91740c8c
-
- Mar 11, 2020
-
-
Michel Weststrate authored
Summary: This pull request re-applies https://github.com/facebook/react-native/pull/28225, thereby reverting https://github.com/facebook/react-native/commit/4bb17944f18e8ecd20633e49ff143f23210cd976, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to https://github.com/facebook/flipper/pull/874) This is the iOS counterpart of https://github.com/facebook/react-native/pull/28275 [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: https://github.com/facebook/react-native/pull/28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI  Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
-
Pascal Hartig authored
Summary: Upgrades Flipper to 0.33.1 for both the Android template and RNTester. ## Changelog [Android] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: https://github.com/facebook/react-native/pull/28275 Test Plan: Still trying to figure out how to get my Gradle setup working again. Until then, CI. Reviewed By: cpojer, mweststrate Differential Revision: D20369480 Pulled By: TheSavior fbshipit-source-id: 048c944819168a352214349f6a83407a587479c9
-
- Mar 07, 2020
-
-
Eloy Durán authored
-
Joshua Gross authored
Summary: A previous PR broke toggling between visible and non-visible password (basically once a password field was made visible, future updates to the keyboardType were effectively ignored, so the password would always be visible). Original PR: https://github.com/facebook/react-native/pull/27523 Changelog: [Internal] Reviewed By: mdvacca, rodrigos-facebook Differential Revision: D19527245 fbshipit-source-id: a5ab343c8a0c6a608171dbfa5afc7536ff241826
-
- Mar 06, 2020
-
-
Eloy Durán authored
-
Eloy Durán authored
This reverts commit ada73a35.
-
- Mar 05, 2020
-
-
Michel Weststrate authored
Summary: This diff updated FlipperKit to be compatible with the latest react-native-flipper version. (nothing changes compared to what is already in the changelog for RN 0.62.0) [iOS][Fixed] - Upgraded FlipperKit to 0.32.2 to ensure compatibility with latest `react-native-flipper` Pull Request resolved: https://github.com/facebook/react-native/pull/28225 Test Plan: Tested by upgrading the ReactNativeFlipperExample (https://github.com/facebook/flipper/tree/master/react-native/ReactNativeFlipperExample) to RN 0.62.0-rc.3 and verified the example plugin works. (In D20221558)  Reviewed By: priteshrnandgaonkar Differential Revision: D20249666 Pulled By: mweststrate fbshipit-source-id: 71a61c4249f8b767c7767d5c6133436c9bc9cf26
-
Pavlos Vinieratos authored
Summary: Adding `xcscheme` files for iOS template back in. They were removed in https://github.com/facebook/react-native/issues/26471 after https://github.com/facebook/react-native/issues/25451. We have reverted the change on `.gitignore`, as this directory is supposed to be in git, but we didn't revert the removed files. Now they are back as well. You can also see here that the two files are still missing, they got removed on rc.0 and are still missing on rc.3. https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.0-rc.3 ## Changelog [iOS] [Changed] - Add `xcscheme` files for iOS template back in. Pull Request resolved: https://github.com/facebook/react-native/pull/28198 Test Plan: `init` a nre project, and check if the files are there or not. The paths are `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp.xcscheme` and `ios/MyApp.xcodeproj/xcshareddata/xcschemes/MyApp-tvOS.xcscheme` Reviewed By: cpojer Differential Revision: D20179447 Pulled By: TheSavior fbshipit-source-id: b0f08c0f32d6bb7630179bc2fe46d9ac10f6c1d7
-
Will Holen authored
Summary: We are currently unintentionally including both libhermes-executor-release.so and libhermes-executor-debug.so in all OSS RN builds. RN tries both in turn, but since they both exist and the release executor is compatible with the debug build, we always get the release executor without debug functionality. While we sort this out, switch the load order. Since the debug executor is not compatible with the release build, so it'll fail to load and try the next one. ChangeLog: [Android] Fix Hermes debugger being disabled by default Reviewed By: mhorowitz Differential Revision: D20163828 fbshipit-source-id: ee4d87f40e42a7c8eedfdb7e1fc17eb3e5966ba5
-
Marc Horowitz authored
Summary: See the comments for more info. Changelog: [Android] [Changed] - Improve exception message when JSC loading fails Reviewed By: tmikov Differential Revision: D19917034 fbshipit-source-id: d846f542c31e9c94edcee240c2935d77d48d1f2a
-
David Vacca authored
Summary: This diff changes the behavior of UIImplementation.resolveViewManager() to return null instead of throwing an exception when trying to find an unexistent viewManager during the computation of constants for view Managers. The C++/JS code manages exceptions and null results when a view manager doesn't exists, this diff simplifies the way this method operates. changeLog: [internal] Reviewed By: rickhanlonii Differential Revision: D19624423 fbshipit-source-id: df31dcfae9a588bf325b61d529cec6ead59fb19d
-
Jason Safaiyeh authored
Summary: Fix for https://github.com/facebook/react-native/issues/27510. Setting the `InputType.TYPE_CLASS_TEXT` flag when `keyboardType` is null or default breaks autoCapitalize. Handle the case when `keyboardType` is null, default, or invalid type. ## Changelog [Android] [Fixed] - Fix setting keyboardType from breaking autoCapitalize Pull Request resolved: https://github.com/facebook/react-native/pull/27523 Test Plan: Added keyboardType prop to RNTester as so ``` <TextInput autoCapitalize="words" keyboardType="default" style={styles.default} /> ```  Reviewed By: makovkastar Differential Revision: D19132261 Pulled By: JoshuaGross fbshipit-source-id: be66f0317ed305425ebcff32046ad4bff06d367f
-
- Feb 25, 2020
-
-
Eloy Durán authored
-
Eloy Durán authored
-
Eloy Durán authored
-
Jason Safaiyeh authored
Summary: Resolve Xcode localization warnings in template ## Changelog [iOS] [Fixed] - Resolve localization warnings Pull Request resolved: https://github.com/facebook/react-native/pull/28046 Test Plan: Create a fresh template app, localization warnings should not happen. Differential Revision: D19873686 Pulled By: hramos fbshipit-source-id: 5db0e7da1048899c4049fe991bc354a6798dfb06
-
Will Holen authored
Summary: Use the latest published release of hermes-engine. Changelog: [Android] [Changed] - Upgraded to Hermes 0.4.0 Reviewed By: mhorowitz Differential Revision: D19866355 fbshipit-source-id: be2bed957bc034d3e6107804229abc2d83e40d40
-
Jason Safaiyeh authored
Summary: Resolve React-RCTText warning: `'UIKeyboardTypeASCIICapableNumberPad' is only available on iOS 10.0 or newer` ## Changelog [iOS] [Fixed] - Resolve React-RCTText Xcode warning Pull Request resolved: https://github.com/facebook/react-native/pull/28054 Test Plan: Build template, React-RCTText should no longer throw a warning. Differential Revision: D19887063 Pulled By: hramos fbshipit-source-id: 3437ee993babd7cdaec259af24526e197acb64bb
-